-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/APPEALS-32376: Re-architect How Caseflow Stores and Processes Hearing Times #20519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Code Climate has analyzed commit 8874a8e and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
…PPEALS-36751 janet/APPEALS-36751 part 2 delete HearingForHearingDaySerializer
ThorntonMatthew
commented
Jan 16, 2024
@@ -1,41 +0,0 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was deleted in order to prune dead code.
…APPEALS-37039 jcohen/APPEALS-37039 : Add "scheduled_in_timezone" Column to "hearings" and "legacy_hearings" Tables
…22649) Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Add RO times to Previously Scheduled section of Daily Docket pages * Use RO tz over complex logic * Update snapshot --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Update recipient timezone to look through appeal if nil elsewhere * Remove redundant conditional from serializers and always pass representative_tz * Refactor for readability * update hearing mailer spec to account for recipient timezone fallback logic * remove empty line --------- Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
This reverts commit 08c9528.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-32376